Repository navigation
Update FBGEMM and enable native AArch64 builds - #967
Closed
gaborkertesz wants to merge 3 commits into
Closed
gaborkertesz wants to merge 3 commits into
gaborkertesz wants to merge 3 commits into
Conversation
Update the bundled LLVM toolchain to support newer AArch64 targets. Clang 23 exposes GCC 14.1's libstdc++ PR115119 in bits/unicode.h (`++this` is rejected). Bump GCC to 14.2.0 as well, which includes the fix, so FBGEMM can build with the updated Clang toolchain. Change-Id: I289d63d263cd34fb2c4dd536b1c1b10aef4a6946
Pass FBGEMM_AARCH64_BUILD_NATIVE to both the standalone CMake build and the Python package build on Arm systems. This enables host-specific compiler options for all FBGEMM targets. Change-Id: Ia49cf43ced97b17d6eeb5703d641725412815553
This version integrates all Arm related fixes and optimizations were upstreamed to FBGEMM recently. Change-Id: Iec81e6dde454dae75523ae9aca130c563c59f6c2
Contributor
|
@excelle08 has imported this pull request. If you are a Meta employee, you can view this in D132326005. |
Contributor
|
@excelle08 merged this pull request in 0cee75d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the FBGEMM benchmark integration and enables native AArch64 builds.
FBGEMM_AARCH64_BUILD_NATIVEfor both standalone and Python package builds on AArch64.