Skip to content

Update FBGEMM and enable native AArch64 builds - #967

Closed
gaborkertesz wants to merge 3 commits into
facebookresearch:mainfrom
gaborkertesz:fbgemm-update
Closed

gaborkertesz wants to merge 3 commits into
facebookresearch:mainfrom
gaborkertesz:fbgemm-update

Conversation

@gaborkertesz

@gaborkertesz gaborkertesz commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

This PR updates the FBGEMM benchmark integration and enables native AArch64 builds.

  • Update LLVM/Clang from 16.0.6 to 23.1.4.
  • Update GCC from 14.1.0 to 14.2.0 to fix the associated libstdc++ compatibility issue.
  • Enable FBGEMM_AARCH64_BUILD_NATIVE for both standalone and Python package builds on AArch64.
  • Update FBGEMM to a newer revision containing recently upstreamed Arm fixes and optimizations.

Update the bundled LLVM toolchain to support newer AArch64 targets.

Clang 23 exposes GCC 14.1's libstdc++ PR115119 in bits/unicode.h
(`++this` is rejected).
Bump GCC to 14.2.0 as well, which includes the fix, so FBGEMM can
build with the updated Clang toolchain.

Change-Id: I289d63d263cd34fb2c4dd536b1c1b10aef4a6946
Pass FBGEMM_AARCH64_BUILD_NATIVE to both the standalone CMake build
and the Python package build on Arm systems.
This enables host-specific compiler options for all FBGEMM targets.

Change-Id: Ia49cf43ced97b17d6eeb5703d641725412815553
This version integrates all Arm related fixes and optimizations
were upstreamed to FBGEMM recently.

Change-Id: Iec81e6dde454dae75523ae9aca130c563c59f6c2
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2026
@meta-codesync

meta-codesync Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@excelle08 has imported this pull request. If you are a Meta employee, you can view this in D132326005.

@meta-codesync meta-codesync Bot closed this in 0cee75d Nov 16, 2026
@meta-codesync meta-codesync Bot added the Merged label Nov 16, 2026
@meta-codesync

meta-codesync Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@excelle08 merged this pull request in 0cee75d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant