Add saved views to Sessions - #2548
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7dc0076c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2c1782a61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3689560010
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
1 participant
What changed\n\n- add Sessions as a first-class saved-view type, including the predefined All view\n- reuse the shared saved-view picker, filter/URL state, and table customization patterns from Events and Stacks\n- persist View Active, filters, stats/chart visibility, column visibility/order/wrapping/widths, and autofill selection\n- add saved Sessions routes, sidebar children, default-view routing support, and focused API/UI/E2E coverage\n\n## Why\n\nSessions should support the same complete saved-view workflow as Events and Stacks instead of maintaining a separate fixed table configuration.\n\n## Verification\n\n- dotnet build: passed\n- SavedViewEndpointTests: 122 passed\n- OpenApiSnapshotTests: 4 passed\n- npm run validate: passed\n- npm run build: passed\n- focused frontend unit tests: 84 passed\n- Sessions saved-view Playwright E2E: passed\n- existing session investigation Playwright E2E: passed\n- localhost App and same-origin API smoke checks: HTTP 200\n\nThe full frontend unit run passed 728 tests and hit one unrelated existing failure in navigation-command.svelte.test.ts. It also fails in isolation on the unchanged test, expecting /next/stack while the current implementation navigates to /next/.\n\n## Breaking changes\n\nNone.