Skip to content

Fix event detail UI consistency - #2547

Merged
ejsmith merged 8 commits into
mainfrom
issue/rataplan-small-ui-fixes
Aug 31, 2026
Merged

Fix event detail UI consistency#2547
ejsmith merged 8 commits into
mainfrom
issue/rataplan-small-ui-fixes

Conversation

@ejsmith

@ejsmith ejsmith commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

  • wrap long Overview, Exception, and Session Events messages without horizontal page-length scrolling
  • add the missing Session Events user column and align its calendar action in normal layout
  • open session-filtered events through the Events All saved view when available so column, wrapping, and width settings carry over
  • correct the sidebar toggle cursor, Environment Machine Name cell layout, and stack-menu icon spacing

Verification

  • npm run validate
  • npm run test:unit -- --run src/lib/features/events/components/views/session-events-navigation.test.ts (4 passed)
  • E2E_URL=https://localhost:33343 npx playwright test e2e/tests/session-investigation.e2e.ts --project=chromium --workers=1 (1 passed)
  • local before/after Playwright capture at 1280 x 900: Overview and Exception scroll widths reduced from 8,337 px to 977 px; Session Events reduced from 8,590 px to 978 px within a 977 px container

Breaking changes

None.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T01:04:12.850122Z 0e83a04 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc61d70c05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87454af8a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

const query = new URLSearchParams({
filter: filter.toFilter(),
time: 'all'
});

P2 Badge Clear saved-view filters when opening session events

When the shared Events All view has been customized with a filter such as type:error, this URL does not produce a session-only list: getCurrentFiltersWithoutTime() merges the cached session expression over the saved view's filter_definitions and retains every filter whose key is not session, so non-error events from the session disappear. Fresh evidence beyond the addressed private-view collision is that this merge also affects the selected shared All view; clear its saved filter keys when constructing this navigation, or carry over only its visual settings.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ejsmith

ejsmith commented Aug 30, 2026

Copy link
Copy Markdown
Member Author

Addressed the current-head saved-filter review in 64fadc7. The Session Events link keeps the shared All view path for visual settings, explicitly clears every supported saved-view filter override, supplies the session through the dedicated session query parameter, and forces all time. Added unit coverage for the complete URL contract and updated the focused browser regression.

@ejsmith

ejsmith commented Aug 30, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64fadc7764

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.Insulation 37% 35% 286
Exceptionless.Core 76% 68% 10366
Exceptionless.Web 85% 70% 8037
Exceptionless.AppHost 38% 41% 147
Summary 79% (25889 / 32853) 68% (12083 / 17829) 18836

@ejsmith

ejsmith commented Aug 30, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 0e83a04f85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ejsmith
ejsmith merged commit 31b564c into main Aug 31, 2026
12 checks passed
@ejsmith
ejsmith deleted the issue/rataplan-small-ui-fixes branch August 31, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant