fix: stamp annotations now support /CA opacity (v2) - #810
Open
marinaionel wants to merge 1 commit into
Open
marinaionel wants to merge 1 commit into
marinaionel wants to merge 1 commit into
Conversation
|
@marinaionel is attempting to deploy a commit to the CloudPDF Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #795 on the v2 line. Stamp annotations had no
opacityfield, so patching one was silently accepted but never actually rendered.Adds
opacity: numbertoPdfStampAnnoObject, matching every other annotation type (Highlight, Ink, Square, etc). The pdfium engine now sets/CAwhen a stamp's appearance is authored and reads it back when parsing a stamp annotation.commitStampnow defaults totool.defaults.opacity ?? 1, the same fallback every other handler already uses.