Skip to content

master does not configure, compile, link or pass tests after the 09-07 batch merge #118

Description

@Kartikey1306

Symptom

master has not configured, compiled, linked or passed a test since the 09-07 batch merge. Every CI — eBoot, eBoot Build & Test, CodeQL and nightly run on master is red, and eos's simulation and nightly "Upstream drift" jobs — which build eBoot at master — are red with it.

Verified on b429354: configure aborts on a duplicate eboot_test_fdt_loader target; with that removed, core/sha512.c fails ×5 on eos_sha512_ctx_t having no member count and core/ed25519_verify.c:303 on a redefined scalarbase; with those fixed, eos_secure_boot, eos_secure_boot_lock_debug and eos_boot_log_append are undefined at link.

Cause

Twenty PRs were merged in ninety minutes on 09-07, each replayed onto a master its author never saw. #55 (written 08-28) restored a stale sha512.c and dropped three sources from eboot_core; #94 and #105 both repaired the Ed25519 verifier and both added scalarbase(); #84/#85 registered the same test target twice; #104 and #103 disagree on the install path's verification order.

Fix

#115.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions