Skip to content

Fix stale test_messages/3 reference in the testing docs - #378

Merged
josevalim merged 1 commit into
elixir-broadway:mainfrom
dajiaohuang:fix-stale-test-message-doc-reference
Sep 17, 2026
Merged

josevalim merged 1 commit into
elixir-broadway:mainfrom
dajiaohuang:fix-stale-test-message-doc-reference

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

The "Testing with Ecto" section of the Broadway module docs refers to
test_messages/3, but that function has been private since v0.6.1, when
test_message/3 and test_batch/3 replaced it. The example directly
below the prose already calls Broadway.test_message/3, so this makes
the sentence consistent with the example and with the current API.

The Ecto sandbox section refers to test_messages/3, but that function
has been private since v0.6.1, when test_message/3 and test_batch/3
replaced it. The example right below already calls test_message/3.
@josevalim
josevalim merged commit fa801e5 into elixir-broadway:main Sep 17, 2026
@josevalim

Copy link
Copy Markdown
Contributor

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants