Skip to content

Remove ascii-armor from keyring - #846

Merged
lewisgoddard merged 1 commit into
mainfrom
remove-ascii-armor
Sep 16, 2026
Merged

lewisgoddard merged 1 commit into
mainfrom
remove-ascii-armor

Conversation

@lewisgoddard

@lewisgoddard lewisgoddard commented Sep 16, 2026

Copy link
Copy Markdown
Member
  • Convert ascii-armored keyring to raw binary.
  • Modify .editorconfig and add .gitattributes to avoid manipulation.

image

0x2d is -, the start of the ascii-armor -----BEGIN PGP SIGNED MESSAGE-----

@nikodunk

nikodunk commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

in-image, you can do this to fix it, agreed it needs to be without armor

sudo mkdir -p /etc/systemd
sudo cp /usr/lib/systemd/import-pubring.pgp /etc/systemd
cd /etc/systemd
sudo gpg --dearmor import-pubring.pgp
rm import-pubring.pgp
sudo mv import-pubring.pgp.gpg import-pubring.pgp
sudo sysupdate update

@nikodunk

Copy link
Copy Markdown
Collaborator

Aha! you're essentially making it binary, and gpg --dearmor strips the headers, base64-decodes, checks CRC, writes back the raw packets. Let's try yours - it's cleaner.

@nikodunk
nikodunk self-requested a review September 16, 2026 17:57

@jumpyvi jumpyvi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nikodunk

Copy link
Copy Markdown
Collaborator

Building straight off this branch https://github.com/elementary/os/actions/runs/35131404110

@lewisgoddard
lewisgoddard merged commit 23664c6 into main Sep 16, 2026
0 of 2 checks passed
@lewisgoddard
lewisgoddard deleted the remove-ascii-armor branch September 16, 2026 17:58
@nikodunk

Copy link
Copy Markdown
Collaborator

With my locally-fixed version, updatectl even now works @jumpyvi
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants