feat: native Date/Map/Set Encoded; query adapters convert to JSON - #874
Open
omegent-app[bot] wants to merge 7 commits into
Open
feat: native Date/Map/Set Encoded; query adapters convert to JSON#874omegent-app[bot] wants to merge 7 commits into
omegent-app[bot] wants to merge 7 commits into
Conversation
Query filters now take Date/Set/Map values. Cosmos/SQL/memory adapters lower those to JSON (ISO strings, arrays, entries), and repository persistence round-trips through Schema.toCodecJson. Use DateFromString / ReadonlySetFromArray / ReadonlyMapFromArray when Encoded must be JSON. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
Unwrap ReadonlySet in includes/includes-any and accept Set or array needles for in. Adapters already JSON-convert those values. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Memory and Disk now convert documents with Schema.toCodecJson(toEncoded) instead of JSON.parse/stringify (which dropped Map/Set). SQL and Cosmos use the same codec on write/read. Repository encode stays Type→Encoded; adapters own JSON. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
JSON-encoded maps are arrays of [key, value] tuples. Add hasKey, hasValue, hasKeyValue (and not*/any/all variants) on the query DSL, implemented in memory, SQLite, Postgres, and Cosmos. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Cosmos/SQL merged StoreConfig.defaultValues (now native Date/Map/Set) into stored JSON before toCodecJson decode. Lower defaults the same way Memory already does. Also use globalThis.Date in schema helpers, Reflect for Error.stackTraceLimit, and Sendgrid send ReturnType so linked-source app typechecks. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Restore Error.stackTraceLimit assignment and Sendgrid ClientResponse callback types. They are unrelated to native Encoded query work. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Schema.Date,ReadonlySet, andReadonlyMapno longer rewrite Encoded to JSON (string/array). Encoded is the native value (Date/Set/Map).The query DSL already types filter values as Encoded, so
where("n", "gt", new Date(...))typechecks. Document-store adapters convert those values to JSON when building queries:Date→ ISO string (Schema.toCodecJson(Schema.Date))Set→ arrayMap→ array of entriesRepository persistence also round-trips through
Schema.toCodecJson, so Cosmos / SQL / disk JSON documents stay compatible. Memory and Disk use the same codec instead ofJSON.parse/stringify(which dropped Map/Set). StoredefaultValuesare JSON-lowered before document decode.JSON Encoded codecs remain as explicit helpers:
DateFromString,ReadonlySetFromArray,ReadonlyMapFromArray. OmegaForm date inputs that take strings should useDateFromString.Map query ops
JSON-encoded maps are arrays of
[key, value]tuples. Query DSL additions onReadonlyMapfields:hasKey/notHasKeyhasValue/notHasValuehasKeyValue/notHasKeyValue(pair isreadonly [K, V])*-any/*-allvariants for multiple keys, values, or pairsAdapters compile these against the encoded tuple array (
EXISTS/p[0]/p[1]in Cosmos,json_each+$[0]/$[1]in SQLite,jsonb_array_elementsin Postgres, in-memory aftertoCodecJson).Breaking
S.DateEncoded isDate, notstringS.ReadonlySetEncoded isSet, notarrayS.ReadonlyMapEncoded isMap, notarrayof tuplesopened by patroza in chat thread Discord · Discord · T3
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.