Skip to content

Cleanup alive monitor config loading - #477

Open
WilliamRoebuck wants to merge 22 commits into
eclipse-score:mainfrom
etas-contrib:feature/alive-mon-new-config
Open

Cleanup alive monitor config loading#477
WilliamRoebuck wants to merge 22 commits into
eclipse-score:mainfrom
etas-contrib:feature/alive-mon-new-config

Conversation

@WilliamRoebuck

Copy link
Copy Markdown
Contributor

This is the first step of a refactor to better integrate alive supervision and launch manager. The main change in this PR is constructing alive supervision objects component by component using the new config, instead of all components at once, stage by stage. In addition, the PR:

  • Removed unused config & constants
  • Replaced many strings with IdentifierHashes
  • Removed alive monitor config wrappers

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 8e42f914-9a62-43a7-a461-bf0729034c52
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (42 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (152 packages loaded, 3161 targets configured)

Analyzing: target //:license-check (164 packages loaded, 6285 targets configured)

Analyzing: target //:license-check (164 packages loaded, 6285 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9567 targets configured)

Analyzing: target //:license-check (176 packages loaded, 11463 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11589 targets configured).
[7 / 15] [Prepa] Creating runfiles tree bazel-out/k8-fastbuild/bin/license.check.license_check.runfiles
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.155s, Critical Path: 0.21s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@WilliamRoebuck
WilliamRoebuck marked this pull request as ready for review August 17, 2026 10:30
Comment thread score/launch_manager/src/daemon/src/common/alive_interface_path.hpp Outdated
Comment thread score/launch_manager/src/daemon/src/common/alive_interface_path.hpp Outdated
Comment thread score/launch_manager/src/daemon/src/alive_monitor/details/daemon/PhmDaemon.cpp Outdated
Comment thread score/launch_manager/src/daemon/src/alive_monitor/details/daemon/PhmDaemon.cpp Outdated
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval August 20, 2026 11:12 — with GitHub Actions Active
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval August 20, 2026 11:12 — with GitHub Actions Active
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval August 21, 2026 10:57 — with GitHub Actions Active
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval August 21, 2026 10:57 — with GitHub Actions Active

@MaciejKaszynski MaciejKaszynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however I am not the most familiar with the alive monitoring component so @NicolasFussberger could you also have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants