Repository navigation
Add extension_name property to EasyBlock & do NOT inherit parent extension_name - #5313
Merged
Merged
Conversation
As it is expected that the fallback of `extension_name` to `name` is often useful it makes sense to have a unique place for that.
Contributor
Author
|
@boegel Have you considered this question? Would need deciding before shipping.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it is expected that the fallback of
extension_nametonameis often useful it makes sense to have a unique place for that.The test discovered a critical flaw: We need to reset
extension_nameinExtension.__init__@boegel Can you add this to the next release before we ship the
extension_namefeature?Can also extract the bugfix although the test is easier with the property
Related: Shall we support templates in
extension_nameof extensions?We currently support templates in the name (why? I don't see a use case) and I kept the existing mechanism in #5259 such that:
('foo', 1, {extension_name: "%(name)s-%(version)s"})would resolveextension_nametofoo-1but I'm not sure that makes sense and it would complicate things for us if we want to useextension_nameto derive template values as we would need to resolve extension templates once, then resolve extension_name, then resolve again, i.e. what we do ineasybuild-framework/easybuild/framework/easyblock.py
Lines 703 to 710 in 2a58220