Repository navigation
Conversation
Flamefire
force-pushed
the
dict-items
branch
2 times, most recently
from
September 16, 2026 08:45
1c6e3e4 to
9c610ee
Compare
Flamefire
force-pushed
the
dict-items
branch
2 times, most recently
from
October 2, 2026 07:02
790682d to
87c1dc9
Compare
This resolves a few warnings generated by PyLint which make the tests a bit simpler/clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a few warnings generated by PyLint which make the tests a bit simpler/clearer.
E.g.
stdout, stderr = self.run_main(args, raise_error=True)is used but then the variables are never used.When reading this code again it is unclear if this is intentional
Using
dict.itemsis shorter and makes it easier to see what the dict is made of, e.g.: