Conversation
Flamefire
force-pushed
the
skip-markers-5
branch
5 times, most recently
from
September 3, 2026 12:20
1f86249 to
099a05a
Compare
boegel
changed the title
skipTest rather than faulty copy-paste of return conditions: Skip marker for GitHub tests 2
Flamefire
force-pushed
the
skip-markers-5
branch
from
September 15, 2026 13:01
787cd2d to
b60d765
Compare
The pip-installable pysvn is incomplete and the full one is not easy to install.
For PRs silently skip the tests when no token is available else use a skip. On GHA force enable the tests when the source repo is 'easybuilds' so a token is expected to be available.
As that is used a lot use that for better describing the purpose.
Successful output looks like this > ...............................................s...................................................................................... > ................................................................................................................... > ---------------------------------------------------------------------- > Ran 946 tests in 714.512s > > OK (skipped=3) We only care about the part until "Ran xxx tests" not including the divider (dashes). Also we can ignore any lines with just "s" and ".".
Simply return if `$TEST_EASYBUILD_MODULES_TOOL` is not set to Lmod. This avoids any "skip" output on CI
Flamefire
force-pushed
the
skip-markers-5
branch
from
September 30, 2026 10:44
b60d765 to
7af815f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #4188