Repository navigation
Rename Divider color prop to colorWeight with light/medium/dark values - #2576
Closed
anuj-pal27 wants to merge 1 commit into
Closed
anuj-pal27 wants to merge 1 commit into
anuj-pal27 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks first for your aportation and interest, but we won't be able to merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Description
Renamed the
DxcDividercolorprop tocolorWeightand changed its values fromlightGrey | mediumGrey | darkGreytolight | medium | dark(defaultmedium), since the color comes from neutral tokens and isn't always grey. Visual output is unchanged. Updated internal usages, stories and website docs.Breaking change:
color="darkGrey"→colorWeight="dark"(same forlight/medium).Closes #2365