Repository navigation
Conversation
| ContainerBorderProperties as DxcContainerBorderProperties, | ||
| ContainerBorder as DxcContainerBorder, | ||
| ContainerOutline as DxcContainerOutline, | ||
| ContainerOverflow as DxcOverflow, |
There was a problem hiding this comment.
It should be DxcContainerOverflow, same as DxcContainerOutline
| } from "./grid/types"; | ||
| export type { | ||
| HeaderProps as DxcHeaderProps, | ||
| HeaderMainNavPropsType as DxcHeaderMainNavPropsType, |
There was a problem hiding this comment.
"PropsType" at the end should be remove, same as all the other files
There was a problem hiding this comment.
Check how this changes affect utils.ts
There was a problem hiding this comment.
check how this affects the stories file of the DataGrid
There was a problem hiding this comment.
check stories of this component
There was a problem hiding this comment.
check test files of this component
There was a problem hiding this comment.
check stories of Grid component
| @@ -1,7 +1,7 @@ | |||
| import styled from "@emotion/styled"; | |||
| import StatusLightPropsType from "./types"; | |||
| import iStatusLightProps from "./types"; | |||
There was a problem hiding this comment.
typo in "iStatusLightProps" "i" should be removed
| >; | ||
|
|
||
| type ToastContextType = (toast: ToastType, semantic: Semantic) => () => void; | ||
| type ToastContext = (toast: ToastType, semantic: Semantic) => () => void; |
There was a problem hiding this comment.
ToastContext is already the name of the React context in toast/ToastContext.tsx (imported as ToastContext in ToastsQueue.tsx), so this type name collides with it. Could we keep the original ToastContextType or use a name that describes the signature, like AddToast?
|
|
||
| export default ToastPropsType; | ||
| export type { ToastProps as default }; | ||
| export type { |
There was a problem hiding this comment.
why did we remove CommonProps from the export?
There was a problem hiding this comment.
CommonProps is not used outside of types. Also there is not benefit of exporting it alongside other types.
2 participants
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Types exported with the components, but only those deemed to be useful to users.
CoreTokens and AliasTokens are also exported.
Aditionally some improvements to typings were done avoiding breaking changes.