Skip to content

lib: strnum - Reject empty string in str_to_float() and str_to_double() #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nishuuzz wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

lib: strnum - Reject empty string in str_to_float() and str_to_double() #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f0727
lib: strnum - Reject empty string in str_to_float() and str_to_double()
Nishuuzz Aug 25, 2026
502d2a8
lib-test: strnum - Fix test name in test_str_to_float()
Nishuuzz Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/lib/strnum.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,9 @@ int str_to_float(const char *str, float *num_r)
{
char *endp;
float num = strtof(str, &endp);
if (*endp != '\0')
/* strtof() performs no conversion for an empty string and leaves endp
pointing at str, so the *endp check alone would accept "" as 0. */
if (endp == str || *endp != '\0')
return -1;

*num_r = num;
Expand All @@ -471,7 +473,9 @@ int str_to_double(const char *str, double *num_r)
{
char *endp;
double num = strtod(str, &endp);
if (*endp != '\0')
/* strtod() performs no conversion for an empty string and leaves endp
pointing at str, so the *endp check alone would accept "" as 0. */
if (endp == str || *endp != '\0')
return -1;

*num_r = num;
Expand Down
4 changes: 3 additions & 1 deletion src/lib/test-strnum.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,10 @@ static void test_str_to_float(void)
INVALID(0.1x),
INVALID(0.1.2),
INVALID(bad),
/* strtof()/strtod() consume nothing here, so endp stays at str */
{ "", -1, 0 },
};
test_begin("str_to_int");
test_begin("str_to_float");
for (i = 0; i < N_ELEMENTS(tests); ++i) {
float val = 1234.0;
double val2 = 1234.0;
Expand Down