Add BuildCheck for WriteLinesToFile without Overwrite - #14690
Open
iamhaseebn wants to merge 1 commit into
Open
Conversation
iamhaseebn
temporarily deployed
to
copilot-pat-pool
August 11, 2026 19:08 — with
GitHub Actions
Inactive
iamhaseebn
temporarily deployed
to
copilot-pat-pool
August 11, 2026 19:09 — with
GitHub Actions
Inactive
Member
Member
|
Love it, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11927
Context
WriteLinesToFiledefaultsOverwritetofalse, so repeated incremental builds can append duplicate content whenOverwriteis omitted. This adds the proposed opt-in style check without changing existing build behavior.Changes Made
WriteLinesToFileinvocations that omitOverwrite.Overwrite="true"orOverwrite="false"and match MSBuild names case-insensitively.Testing
./build.sh -v quiet- passed with zero warnings or errors.WriteLinesToFileBuildChecktests - passed.Notes
The check is opt-in, so existing builds are unaffected unless it is explicitly enabled.