Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
kocaemre
force-pushed
the
fix-841-structured-publish-text-latex
branch
from
October 3, 2026 21:05
0e9dfd4 to
c30bb1a
Compare
Author
|
Follow-up: fixed the Black formatting drift that made the CI Verification after the formatting fix:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attributes.publishmapping entries in text and LaTeX publishers instead of passing dicts toitem.attribute().BasePublisherfor non-HTML tabular output.fieldsmapping syntax.Why
Fixes #841.
Test plan
uv run pytest doorstop/core/publishers/tests/test_publisher_text.py::TestModule::test_lines_text_item_with_structured_publish_attribute doorstop/core/publishers/tests/test_publisher_latex.py::TestPublisherModule::test_lines_latex_item_with_structured_publish_attribute -qfailed before the fix withTypeError: cannot use 'dict' as a dict key.uv run pytest doorstop/core/publishers/tests/test_publisher_text.py::TestModule::test_lines_text_item_with_structured_publish_attribute doorstop/core/publishers/tests/test_publisher_latex.py::TestPublisherModule::test_lines_latex_item_with_structured_publish_attribute -q→ 2 passed.uv run pytest doorstop/core/publishers/tests/test_publisher_text.py doorstop/core/publishers/tests/test_publisher_latex.py -q→ 32 passed.uv run python -m py_compile doorstop/core/publishers/base.py doorstop/core/publishers/text.py doorstop/core/publishers/latex.py doorstop/core/publishers/tests/test_publisher_text.py doorstop/core/publishers/tests/test_publisher_latex.pygit diff --checkNotes
uv run pytest doorstop/core/publishers/tests -qwas attempted: 128 passed, 1 existing HTML linkify assertion failed outside this change (test_lines_html_item_linkify, mock href escaping difference under this local Python 3.14 environment).