fix: update sidebar anchor activation logic - #2779
Conversation
|
@sy-records is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks very much @sy-records ! I am not quite sure of the needed flow to manually test this fix, I tried this but both docsify.js.org and PR Preview build seem to give the same results?
Can you provide more details on what an example test flow would be? Thank you! |
|
The content of showcase is a remote file, so it may not be loaded. You can search for the contents of local files, such as configuration items. |
paulhibbitts
left a comment
There was a problem hiding this comment.
Thanks for the clarification @sy-records . Here is my manual test flow:
- Click a sidebar item (e.g. Quick start)
- Search "html", click the first result
- Click the 脳 clear button on the search box to dismiss results
On https://docsify.js.org/ "Quick start" loses its highlight, and as intended the new PR Build Preview HTML remains highlighted. Looks good!
Summary
When using the search function, the highlighted anchor in the sidebar does not update after clicking.
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: