Skip to content

Scope uninstall state to SDK directory #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agocke merged 3 commits into from
Aug 9, 2026
Merged

Scope uninstall state to SDK directory #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e8ff60
Scope uninstall state to SDK directory
agocke Aug 8, 2026
d5947b7
Test directory-scoped uninstall state
agocke Aug 8, 2026
ac37c85
Test unscoped uninstall across directories
agocke Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/dnvm/UninstallCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public static async Task<int> Run(ManifestLock @lock, DnvmEnv env, Logger logger
DeleteAspnets(env, aspnetToRemove, logger);
DeleteWins(env, winToRemove, logger);

manifest = UninstallSdk(manifest, sdkVersion);
manifest = UninstallSdks(manifest, sdksToRemove);
await @lock.WriteManifest(env, manifest);

return 0;
Expand Down Expand Up @@ -137,18 +137,18 @@ private static void DeleteWins(DnvmEnv env, IEnumerable<(SemVersion, SdkDirName)
}
}

private static Manifest UninstallSdk(Manifest manifest, SemVersion sdkVersion)
private static Manifest UninstallSdks(
Manifest manifest,
HashSet<(SemVersion Version, SdkDirName Dir)> sdksToRemove)
{
// Delete SDK version from all directories
var newVersions = manifest.InstalledSdks
.Where(sdk => sdk.SdkVersion != sdkVersion)
.Where(sdk => !sdksToRemove.Contains((sdk.SdkVersion, sdk.SdkDirName)))
.ToEq();

// Also remove the SDK version from RegisteredChannels.InstalledSdkVersions
var updatedChannels = manifest.RegisteredChannels.Select(channel =>
{
var updatedInstalledVersions = channel.InstalledSdkVersions
.Where(version => version != sdkVersion)
.Where(version => !sdksToRemove.Contains((version, channel.SdkDirName)))
.ToEq();
return channel with { InstalledSdkVersions = updatedInstalledVersions };
}).ToEq();
Expand Down
81 changes: 81 additions & 0 deletions test/UnitTests/UninstallTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,87 @@ public Task LtsAndPreview() => RunWithServer(async (server, env) =>
Assert.True(env.DnvmHomeFs.DirectoryExists(UPath.Root / "preview" / "templates" / previewVersion.ToString()));
});

[Fact]
public Task DirectorySpecificUninstallKeepsOtherCopy() => RunWithServer(async (server, env) =>
{
var version = new SemVersion(8, 0, 100);
var defaultDir = DnvmEnv.DefaultSdkDirName;
var alternateDir = new SdkDirName("alternate");
var manifest = Manifest.Empty
.AddSdk(version, sdkDirParam: defaultDir)
.AddSdk(version, sdkDirParam: alternateDir);
manifest = manifest with
{
RegisteredChannels =
[
new RegisteredChannel
{
ChannelName = new Channel.Latest(),
SdkDirName = defaultDir,
InstalledSdkVersions = [version],
},
new RegisteredChannel
{
ChannelName = new Channel.VersionedMajorMinor(8, 0),
SdkDirName = alternateDir,
InstalledSdkVersions = [version],
},
]
};
await Manifest.WriteManifestUnsafe(env, manifest);

Assert.Equal(0, await UninstallCommand.Run(env, _logger, version, alternateDir));

var finalManifest = await Manifest.ReadManifestUnsafe(env);
Assert.Contains(finalManifest.InstalledSdks,
sdk => sdk.SdkVersion == version && sdk.SdkDirName == defaultDir);
Assert.DoesNotContain(finalManifest.InstalledSdks,
sdk => sdk.SdkVersion == version && sdk.SdkDirName == alternateDir);
Assert.Contains(finalManifest.RegisteredChannels,
channel => channel.SdkDirName == defaultDir
&& channel.InstalledSdkVersions.Contains(version));
Assert.Contains(finalManifest.RegisteredChannels,
channel => channel.SdkDirName == alternateDir
&& !channel.InstalledSdkVersions.Contains(version));
});

[Fact]
public Task UninstallWithoutDirectoryRemovesAllCopies() => RunWithServer(async (server, env) =>
{
var version = new SemVersion(8, 0, 100);
var defaultDir = DnvmEnv.DefaultSdkDirName;
var alternateDir = new SdkDirName("alternate");
var manifest = Manifest.Empty
.AddSdk(version, sdkDirParam: defaultDir)
.AddSdk(version, sdkDirParam: alternateDir);
manifest = manifest with
{
RegisteredChannels =
[
new RegisteredChannel
{
ChannelName = new Channel.Latest(),
SdkDirName = defaultDir,
InstalledSdkVersions = [version],
},
new RegisteredChannel
{
ChannelName = new Channel.VersionedMajorMinor(8, 0),
SdkDirName = alternateDir,
InstalledSdkVersions = [version],
},
]
};
await Manifest.WriteManifestUnsafe(env, manifest);

Assert.Equal(0, await UninstallCommand.Run(env, _logger, version));

var finalManifest = await Manifest.ReadManifestUnsafe(env);
Assert.DoesNotContain(finalManifest.InstalledSdks, sdk => sdk.SdkVersion == version);
Assert.All(finalManifest.RegisteredChannels,
channel => Assert.DoesNotContain(version, channel.InstalledSdkVersions));
});

[Fact]
public Task UninstallMessage() => RunWithServer(async (server, env) =>
{
Expand Down
Loading