Repository navigation
Conversation
The background "sleep 3" loop ignores SIGINT. Ctrl+C kills the build and, without a SIGINT trap, bash re-raises SIGINT and skips the EXIT trap, so the loop survives and keeps stderr open. Callers that wait for that pipe, such as package-manager hooks, hang until it is killed. Redirect the loop's stderr to /dev/null, exit 130 on SIGINT so the EXIT trap runs, and pass each jobs -p pid to kill separately. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
I'm a bit confused by the "Test plan" checklist, are you actually adding tests to the pull request or what? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sleep 3; echo .) ignores SIGINT. After Ctrl+C, bash re-raises SIGINT and skips the EXIT trap, so the loop keeps running and holds the caller's stderr open. Anything waiting for that pipe to close (a package-manager hook, for example) hangs./dev/null, exit 130 on SIGINT so the existing EXIT trap runs, and pass eachjobs -ppid tokillseparately. A quoted"$j"is one argument whenjobs -pprints more than one line.Test plan
makea module, send SIGINT to the dkms process group, and confirm dkms exits 130 and does not leave the progress loop behindMade with Cursor