Repository navigation
Conversation
… error (#390) Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
|
React Doctor found 1 new issue in 1 file · 1 warning · score 91 / 100 (Great) · 1 fixed · vs 1 warning
Reviewed by React Doctor for commit |
Contributor
|
Preview deployment ready: https://agent-comapeo-cloud-app-issu-vmlv.comapeo-cloud-app.pages.dev Commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #390
What
src/screens/MapScreen/MapScreen.tsx: dismissing the map-surface reference-overlay error (reference-overlay-map-erroralert) no longer drops keyboard focus to<body>. The dismiss handler now callsrequestAnimationFrame(() => mapPanelRef.current?.focus()), mirroring the idiom established in fix(map): restore authored layer error dismissal + maplibre-gl 6.x security upgrade #361 (AuthoredLayersControl.tsx).ref+tabIndex={-1}(programmatic-focus-only; not added to tab order). The MapLibre canvas is re-created by the map engine, so it is not a reliable programmatic focus target.tests/unit/screens/MapScreen/MapScreen.test.tsx(RED-first: verified failing pre-fix withactiveElement === body), asserting focus lands on the map panel after dismissal.Audit (per issue)
AuthoredLayersControl) already returns focus internally (fix(map): restore authored layer error dismissal + maplibre-gl 6.x security upgrade #361).Review
The PR appears safe to merge; the focus-restoration behavior is narrowly implemented and covered by a targeted regression test.
Summary
This PR restores keyboard focus after dismissing the map-surface reference-overlay error.
Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..."