Fix java version matching

[David Shen (pantherman594)]

Fixes finding versions that include a +1. Also uses the /versions/all endpoint, which returns a comma-delimited list of all available versions, to simplify the version parsing.

Closes #1712

[Copilot]

Pull request overview

This PR updates the Java feature’s SDKMAN version resolution logic to correctly handle SDKMAN identifiers that include + build metadata (e.g. 21.0.12+1-ms) and simplifies parsing by switching from sdk list table parsing to the /versions/all endpoint.

Changes:

• Update find_version_list to fetch available versions from https://api.sdkman.io/.../versions/all and adjust regex matching to allow +... metadata for Java distributions.
• Refactor sdk_install / find_version_list call signatures to remove the old prefix/suffix parsing approach.
• Bump the feature version to 1.8.2.

Show a summary per file

File	Description
src/java/install.sh	Switches version discovery to /versions/all and updates matching logic to handle + build metadata; refactors install helper signatures.
src/java/devcontainer-feature.json	Bumps feature version to 1.8.2.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Suppressed comments (2)

src/java/install.sh:286

• When selecting a partial match from version_list, the code builds a grep -E pattern from user input but only escapes dots. With the newly-supported + versions (e.g. users specifying 21.0.12+1), + (and other regex metacharacters) will be interpreted by grep and can cause wrong matches or no match.

        find_version_list "$install_type" version_list "${requested_version}"
        if [ "${requested_version}" = "latest" ] || [ "${requested_version}" = "current" ]; then
            requested_version="$(echo "${version_list}" | head -n 1)"
        else
            set +e

src/java/install.sh:279

• The lts branch picks head -n 1 from version_list but never validates it. If the version list fetch/parsing fails and returns empty, sdk install is invoked with an empty version and silently installs SDKMAN’s default candidate (the failure mode described in #1712).

    elif [ "${requested_version}" = "lts" ]; then
            find_version_list "$install_type" version_list "${requested_version}"
            requested_version="$(echo "${version_list}" | head -n 1)"
    elif echo "${requested_version}" | grep -oE "${full_version_check}" > /dev/null 2>&1; then

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Lite

[Kaniska (Kaniska244)]

Hi David Shen (@pantherman594),

Thank you for the contribution. Would you please accept the license agreement and take a look at the review comments.

[David Shen (pantherman594)]

@microsoft-github-policy-service agree

[Kaniska (Kaniska244)]

LGTM. To be further reviewed by maintainers.

One small observation, although not an absolute necessity, it could have been great to have couple of extra test cases such as below:

    "install_additional_java_versions": {
        "image": "ubuntu:noble",
        "features": {
            "java": {
                "version": "25",
                "additionalVersions": "21"
            }
        }
    },
    "install_java_8_ms_distro_debian": {
        "image": "mcr.microsoft.com/devcontainers/base:debian",
        "features": {
            "java": {
                "version": "8",
                "jdkDistro": "ms"
            }
        }
    }

install_additional_java_versions.sh script:

#!/bin/bash

set -e

# Optional: Import test library
source dev-container-features-test-lib

check "java version openjdk 25 installed as default" grep "openjdk 25\." <(java --version)
check "java version 21 installed as additional version" grep "^21\." <(ls /usr/local/sdkman/candidates/java)

# Report result
reportResults

install_java_8_ms_distro_debian.sh script:

#!/bin/bash

set -e

# Optional: Import test library
source dev-container-features-test-lib

check "java version openjdk 8 installed" /bin/bash -c 'java -version 2>&1 | grep "openjdk version \"1.8\."'

# Report result
reportResults