Repository navigation
Fix from.flake sources - #33
Merged
Merged
Conversation
sini
reviewed
Oct 18, 2026
sini
left a comment
sini
left a comment
Contributor
There was a problem hiding this comment.
Confirmed the fix. In templates/flake, the root nixpkgs points at lock node nixpkgs_2. Main picks the node literally named nixpkgs, which is home-manager's (/nix/store/kjqiqv5q…-source). This branch gives /nix/store/84xbks2h…-source, the same path as (builtins.getFlake "path:…").inputs.nixpkgs.outPath. just ci passes (53/53).
Two small things:
- A leftover
builtins.trace(inline). Any lock with a follows-path root input printstrace: <node>; I hit it with a probe lock that adds"nixpkgs-hm": ["home-manager", "nixpkgs"]to the root inputs. - A test would keep this from regressing: a fixture
flake.lockwhere a root input name differs from its node name (likenixpkgs→nixpkgs_2), plus one follows-path root input.
Merged
instead if loading all nodes, which is lead to different inputs than native flake. Also preserve node.locked attrs from flake.lock (not only outPath)
jbgi
force-pushed
the
better-from-flake
branch
from
October 18, 2026 08:29
aa4c79f to
a2bc4f0
Compare
vic
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
from.flakeload flake inputs wrong, eg.inputs.nixpkgsintemplate/flakeis not the same revision than with native flake load. Fixed by reusing same logic as in flake-compat.