Repository navigation
Conversation
|
reopen when it is not a draft |
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static review at f34f8ee found no implementation defect in the shared output preparation, readiness gate, or source renames. A regression coverage suggestion follows. No builds, runtime tests or CI diagnostics were performed; author-reported checks were not independently rerun.
f34f8ee to
7a5aa74
Compare
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static incremental review found that the new DFT+U regression is registered for a build configuration that cannot run it. The original first-step coverage request is addressed by the new assertions; a bounded follow-up is in that thread. No builds or runtime tests were run.
7a5aa74 to
2bfbea9
Compare
|
We don't recommend setting up tests this way, i.e. a standalone Python script registered with |
|
Thanks for the guidance on Autotest conventions. After reconsidering the scope and existing coverage, I don't think this PR needs an additional regression case or unit test. The existing DFT+U unit tests cover matrix loading and output helpers, and the PW Autotest cases cover numerical results; adding a unit test for those helpers would repeat existing checks. I therefore removed the standalone Python test and its CTest registration in |
Summary
ESolver_KS::iter_init()for both PW and LCAO, removing duplicate setup calls.dftu_base_read.cppanddftu_base_write.cpp, updating the CMake and legacy Makefile lists. Their contents are unchanged.occ_mat.txtat electronic step 1 when a matrix was loaded from file, using the same readiness decision as the numbered snapshot. A fresh PW run still recordsN/Ain its first numbered snapshot.Verification
develop, which includes the upstream lightweightabacus_input_yamlRead the Docs build target (Docs(RTD): build only the INPUT-registry dumper, not all of ABACUS #8248). The prior documentation build timed out at 900 seconds while compiling the fullinstalltarget; the newabacus-developdoc build passed in 141 seconds, and theabacus-rtdpreview check also passed. No documentation configuration is changed by this PR.cmake -S . -B /tmp/abacus-dftu-rename-build -DBUILD_TESTING=ON -DENABLE_LCAO=ON -DENABLE_MPI=ON -DENABLE_LIBXC=OFF -DENABLE_ELPA=OFF: configured. ELPA was disabled locally because this machine's ELPA headers and library do not link together.cmake --build /tmp/abacus-dftu-rename-build --target abacus_basic_para MODULE_PW_dftu_base_test MODULE_DFTU_base_io -j 8: built.OMP_NUM_THREADS=1 ctest --test-dir /tmp/abacus-dftu-rename-build --output-on-failure -R '^(MODULE_PW_dftu_base_test|MODULE_DFTU_base_io)$': 2/2 passed.cmake --build /tmp/abacus-dftu-rename-build --target abacus_input_yaml -j 8and generated INPUT documentation from its YAML output: passed, 614 parameters documented.python3 tools/03_code_analysis/agent_governance_check.py --staged: no findings.git diff --cached --check: passed.Review notes
ESolver_KSprepares ion-step output for both basis paths; PW iteration finish uses existing matrix readiness for both outputs.PARAM.globalv.global_out_dirreference moved from the PW solver call site to the shared KS solver; the PR-wide global dependency count is unchanged.