Repository navigation
Fix searchpath on make install on Xcode 27 - #670
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused guard safely preserves existing behavior while handling Xcode 27’s directory layout.
Review effort: Balanced
Findings: None
What changed in this PR
Updates installation compatibility for Xcode 27’s changed Swift build hierarchy.
Changes:
- Only accesses
.build/.../Moduleswhen that directory exists. - Prevents
make installfrom failing on missing module directories.
| File | Description |
|---|---|
Scripts/install.sh |
Guards module discovery with a directory existence check. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Xcode 27,
make installfails due to hierarchy changes in.build.This PR fixes that copying
Modulesonly when it exists.