Skip to content

docs(fundamentals): fix the pandas setup directory - #543

Merged
yeongseon merged 3 commits into
cubrid-lab:mainfrom
pavanpannati:patch-2
Nov 5, 2026
Merged

yeongseon merged 3 commits into
cubrid-lab:mainfrom
pavanpannati:patch-2

Conversation

@pavanpannati

@pavanpannati pavanpannati commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Closes #523

Fixes the nonexistent cd python/pandas in the pandas setup instructions: the setup now enters fundamentals/pandas, so the unchanged Run commands work from a fresh checkout.

@yeongseon yeongseon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up #523, @pavanpannati. The broken cd python/pandas does need fixing, but this version introduces two new problems:

  1. The Run section stops working. It still says python3 01_read_sql.py and so on, which only works from inside fundamentals/pandas. With this change the reader stays at the repository root, so every Run command fails with "No such file or directory".
  2. cd cubrid-cookbook-python/ assumes where the reader is. It works only from the folder that contains the clone. #523 asks for commands that work from the repository root.

The smallest fix that keeps every later step working is to change only the first line:

cd fundamentals/pandas   # from the repository root
python3 -m venv .venv
source .venv/bin/activate
pip install -r requirements.txt

Two smaller things:

  • The PR title check requires a Conventional Commits title, for example docs(fundamentals): fix the pandas setup directory.
  • Please add Closes #523 to the description so the issue closes on merge.

I have approved the CI runs for this PR, so you will see the results after your next push.

@pavanpannati pavanpannati changed the title Update setup instructions for pandas environment fix the pandas setup directory Oct 30, 2026
@pavanpannati pavanpannati changed the title fix the pandas setup directory update pandas Oct 30, 2026
@pavanpannati pavanpannati changed the title update pandas docs(fundamentals): fix the pandas setup directory Nov 2, 2026
@pavanpannati

Copy link
Copy Markdown
Contributor Author

Thanks for picking up #523, @pavanpannati. The broken cd python/pandas does need fixing, but this version introduces two new problems:

  1. The Run section stops working. It still says python3 01_read_sql.py and so on, which only works from inside fundamentals/pandas. With this change the reader stays at the repository root, so every Run command fails with "No such file or directory".
  2. cd cubrid-cookbook-python/ assumes where the reader is. It works only from the folder that contains the clone. bug: Fix the nonexistent pandas directory in setup instructions #523 asks for commands that work from the repository root.

The smallest fix that keeps every later step working is to change only the first line:

cd fundamentals/pandas   # from the repository root
python3 -m venv .venv
source .venv/bin/activate
pip install -r requirements.txt

Two smaller things:

  • The PR title check requires a Conventional Commits title, for example docs(fundamentals): fix the pandas setup directory.
  • Please add Closes #523 to the description so the issue closes on merge.

I have approved the CI runs for this PR, so you will see the results after your next push.

I hope issue #543 closes look into it, notify me if there any other issues

@pavanpannati pavanpannati changed the title docs(fundamentals): fix the pandas setup directory docs: update setup instructions for pandas environment Nov 3, 2026

@yeongseon yeongseon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the Run commands consistent with the new working directory

The Setup block now leaves the reader at the repository root (cd cubrid-cookbook-python/), but the Run block still uses python3 01_read_sql.py through 06_export_csv.py. Those files live under fundamentals/pandas/, so following Setup and Run in sequence fails with a file-not-found error.

Please add cd fundamentals/pandas before the Run commands, or prefix all six script paths with fundamentals/pandas/. Validate the two blocks together from a fresh checkout; the current green documentation checks did not catch this mismatch.

@yeongseon yeongseon changed the title docs: update setup instructions for pandas environment docs(fundamentals): fix the pandas setup directory Nov 5, 2026
@yeongseon

Copy link
Copy Markdown
Contributor

Thanks for this, @pavanpannati. To finish it, I pushed the single-line change suggested in the review: cd fundamentals/pandas from the repository root, keeping pip install -r requirements.txt so the Run commands work. I also updated the title and set Closes #523 in the description.

@yeongseon
yeongseon dismissed their stale review November 5, 2026 03:22

The requested one-line fix, title and Closes #523 are applied in 3841fb7.

@yeongseon

Copy link
Copy Markdown
Contributor

Maintainer review (delegated): the diff is now only cd fundamentals/pandas from the repository root; that directory holds requirements.txt and the six Run scripts, so setup and Run work together. My earlier change request is addressed and dismissed. CI Gate, docs-sync and PR title pass. Merging.

@yeongseon
yeongseon merged commit 1ac2b8f into cubrid-lab:main Nov 5, 2026
29 of 31 checks passed
@pavanpannati

Copy link
Copy Markdown
Contributor Author

Thank you @yeongseon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Fix the nonexistent pandas directory in setup instructions

2 participants