Repository navigation
docs(fundamentals): fix the pandas setup directory - #543
Conversation
yeongseon
left a comment
There was a problem hiding this comment.
Thanks for picking up #523, @pavanpannati. The broken cd python/pandas does need fixing, but this version introduces two new problems:
- The Run section stops working. It still says
python3 01_read_sql.pyand so on, which only works from insidefundamentals/pandas. With this change the reader stays at the repository root, so every Run command fails with "No such file or directory". cd cubrid-cookbook-python/assumes where the reader is. It works only from the folder that contains the clone. #523 asks for commands that work from the repository root.
The smallest fix that keeps every later step working is to change only the first line:
cd fundamentals/pandas # from the repository root
python3 -m venv .venv
source .venv/bin/activate
pip install -r requirements.txtTwo smaller things:
- The PR title check requires a Conventional Commits title, for example
docs(fundamentals): fix the pandas setup directory. - Please add
Closes #523to the description so the issue closes on merge.
I have approved the CI runs for this PR, so you will see the results after your next push.
I hope issue #543 closes look into it, notify me if there any other issues |
yeongseon
left a comment
There was a problem hiding this comment.
[P2] Keep the Run commands consistent with the new working directory
The Setup block now leaves the reader at the repository root (cd cubrid-cookbook-python/), but the Run block still uses python3 01_read_sql.py through 06_export_csv.py. Those files live under fundamentals/pandas/, so following Setup and Run in sequence fails with a file-not-found error.
Please add cd fundamentals/pandas before the Run commands, or prefix all six script paths with fundamentals/pandas/. Validate the two blocks together from a fresh checkout; the current green documentation checks did not catch this mismatch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for this, @pavanpannati. To finish it, I pushed the single-line change suggested in the review: |
|
Maintainer review (delegated): the diff is now only |
|
Thank you @yeongseon |
Closes #523
Fixes the nonexistent
cd python/pandasin the pandas setup instructions: the setup now entersfundamentals/pandas, so the unchanged Run commands work from a fresh checkout.