Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ linters:
presets:
# `comments` preset removed: revive's `exported` (every exported symbol
# needs a doc comment starting with its name) and `package-comments`
# (every package needs a doc comment) are now enforced org-wide.
# All consumer repos were updated before this change was propagated.
# (every package needs a doc comment) are enforced.
- std-error-handling
- common-false-positives
- legacy
Expand All @@ -97,14 +96,12 @@ linters:
# (gocyclo + gocognit). Both over-fire on idiomatic Go test code: a
# thorough table-driven / property / fuzz test is a loop + t.Run closures
# + per-case assertion guards, which gocognit's nesting model scores high
# without that being a smell. A 2026-06 audit put clean gold-standard
# libraries' flagship tests at cognitive 36-72 (atomicfile TestPendingFile
# is 72) and ~320 test funcs org-wide over 15; gating those would force
# ~320 //nolint or the splitting of cohesive table tests, degrading the
# suites. golangci also can't set a test-only threshold (min-complexity is
# global), so the prod gate of 15 can't coexist with a lenient test bar.
# Test complexity is judged in context instead: the test-review agent's
# smell catalog (Eager Test, Conditional Test Logic) plus human review.
# without that being a smell: clean table tests score cognitive 36-72,
# and gating them would force a //nolint or the splitting of cohesive
# table tests. golangci also can't set a test-only threshold
# (min-complexity is global), so the prod gate of 15 can't coexist with a
# lenient test bar. Test complexity is judged in review instead (Eager
# Test, Conditional Test Logic).
- path: _test\.go
linters:
- dupl
Expand Down Expand Up @@ -186,7 +183,7 @@ formatters:
# builds one identical string ("G702: Command injection via taint analysis")
# for every site and the processor keeps three of them.
#
# Measured 2026-08-27: a corpus where standalone gosec reported 15 G702
# Measured: a corpus where standalone gosec reported 15 G702
# findings reported 3 through golangci-lint, and which 3 survived depended on
# processing order — which is also what made a `//nolint:gosec` directive on a
# taint finding fail `nolintlint` as "unused" on some runs and not others.
Expand Down
2 changes: 1 addition & 1 deletion cliff.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ header = ""
# author's indent depth decided whether a table survived (2 spaces became
# mush, 6 spaces became a code block) with nothing telling them which they
# picked. Unquoted, a fenced block in the commit footer reaches the reader as
# a fenced block. Authoring rules for footers are in git-commits.md.
# a fenced block.
#
# 3. `set_global` is required, and an attribute filter cannot replace it.
# breaking_description falls back to the SUBJECT when a commit has no
Expand Down
6 changes: 3 additions & 3 deletions scripts/collect-licenses.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#!/bin/sh
# Synced from cplieger/ci/configs/collect-licenses.sh. Change it there.
# Copy every linked Go module's license files into the /usr/share/licenses tree of
# attribution.md section 4. usage: collect-licenses.sh --name IMAGE [--out DIR] [--src DIR] [PACKAGE ...]
# Copy every linked Go module's license files into the image's /usr/share/licenses
# tree. usage: collect-licenses.sh --name IMAGE [--out DIR] [--src DIR] [PACKAGE ...]
# A module with no license file fails the build rather than being skipped, because a
# missing text is a section 4(a) breach and the fix is a human decision.
# missing notice is a redistribution breach and the fix is a human decision.
set -eu

OUT=/out/usr/share/licenses
Expand Down
1 change: 0 additions & 1 deletion scripts/repin-sha.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# Synced from cplieger/ci/configs/repin-sha.sh. Change it there.
# Recompute a Dockerfile sha256 integrity pin after Renovate moved its version
# literal, run from postUpgradeTasks because no datasource publishes a sha256.
# Marker convention and enrollment: ci-renovate.md, "Automated sha-pin recompute".
# A marker it cannot honour exits non-zero rather than skipping, because a silent
# miss reproduces the stale-pin build failure the pin exists to catch.
set -eu
Expand Down
3 changes: 1 addition & 2 deletions tests/image-smoke.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
# Runtime image smoke-test harness: start the assembled image, wait for the
# container's own HEALTHCHECK to report healthy, fail fast on an early exit, dump the
# container log tail only on failure. Per-app knobs and hooks come from
# tests/image-smoke.conf beside this script; smoke-tests.md "Pattern B" documents
# every knob, every hook and what each tier proves.
# tests/image-smoke.conf beside this script.
set -eu

IMG="${1:?usage: image-smoke.sh <image-ref>}"
Expand Down
Loading