Fix tracing for StreamWriteRequest - #7757
Open
SungJin1212 wants to merge 3 commits into
Open
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
dosubot
Bot
added
go
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes tracing of write requests when
-distributor.use-stream-pushis enabled.The
PushStreamconnection is opened once at startup and reused by every write request, so its gRPC metadata cannot carry their trace context. As a result every push was traced as a child of the span of the connection, which only ends when the connection closes.This PR propagates the trace context within each message instead, the same way the frontend does over the scheduler stream (
httpgrpcutil.HttpgrpcHeadersCarrier).Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags