fix: only show DCR hint for authorization_code grant type - #116
Open
marekdano wants to merge 1 commit into
Open
Conversation
Signed-off-by: Marek Dano <mk.dano@gmail.com>
a-effort
reviewed
Sep 11, 2026
a-effort
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the diff. No blockers.
The DCR hint is now gated on grantType === 'authorization_code' in both the Client ID and Client Secret fields. The hint text is also reworded to remove the DCR acronym and describe the actual behavior. The i18n strings are updated across all three locales consistently.
The test coverage is correct: it checks that the hint is absent for client_credentials and password grant, and present twice (once per field) for authorization_code. The existing test for the password grant legacy label is preserved and unaffected.
a-effort
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IBM/mcp-context-forge#6466
Summary
"DCR hint shown on Client ID and Secret for the client credentials grant"
Test plan
npx vitest run src/components/mcp-servers/OAuth2Auth.test.tsx— 18 passednpx tsc --noEmitclean