Skip to content

chore: readiness for the agents (MKT-19715) - #145

Closed
pritesh-jain-cstk wants to merge 1 commit into
mainfrom
claude/chore/MKT-19715-readiness
Closed

pritesh-jain-cstk wants to merge 1 commit into
mainfrom
claude/chore/MKT-19715-readiness

Conversation

@pritesh-jain-cstk

Copy link
Copy Markdown

Readiness work for MKT-19715: get Progress Bar ready for the deveco agent routines. Made with the deveco-app-readiness skill; reviewed by a separate agent. Please review and merge by hand.

Ticket Change
MKT-19722 Vitest specs written from the spec replace the hollow spec (it asserted a Promise was truthy): 20 tests, 100% lines, 95% branches. npm test runs once; npm run test:coverage enforces 90%.
MKT-19723 src/index.spec.tsx loads the real entry at #/custom-field (as Contentstack does on dev11) and checks the slider renders. update-app-info.json added (path /#/custom-field, json). ci.yml: lint, typecheck, build, coverage on PRs and main. CLAUDE.md. Unused jotai and nth-check removed. README clone URL, licence (MIT, matching LICENSE) and package.json links fixed.
MKT-19724 dependabot.yml.
— The branch-name hook (validate-branch-name) only allowed `feature
MKT-19732 Not fixed here: two bugs pinned by skipped tests (no catch on SDK init, ErrorBoundary re-throws).

Evidence: lint, typecheck and build pass. The reviewer broke the code 6 ways (default value, saved shape, setData call, load, empty check, pulse payload) and each break fails the suite. Stryker: 66%, with no survivors in the core behaviour.

🤖 Generated with Claude Code

- Tests from the spec replace the hollow spec: 20 tests, 100% lines, 95% branches; `test` runs once, `test:coverage` enforces 90% (MKT-19722)
- Entry test at #/custom-field guards the router; update-app-info.json added (path /#/custom-field, json) (MKT-19723)
- CI on PRs and main: lint, typecheck, build, coverage; Dependabot; CLAUDE.md with verified commands (MKT-19723, MKT-19724)
- Branch-name hook also accepts MKT keys and claude/<type>/<KEY>-<slug> branches (it only allowed the retired ESI project)
- Remove unused jotai and nth-check; README, licence (MIT) and repository links match the repo
- Two known bugs pinned by skipped tests: no catch on SDK init, ErrorBoundary re-throws (MKT-19732)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@snyk-io

snyk-io Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 3 4 25 ✅ Passed
🟡 Medium Severity 2 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

⚠️ Warning: The following vulnerabilities have exceeded their SLA thresholds (days since publication).

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 3 0 30 / 120 days ❌ Failed
🟡 Medium 2 0 90 / 365 days ❌ Failed
🔵 Low 0 0 180 / 365 days ✅ Passed

🟠 High Severity - SLA Breached Issues (with fixes)

Showing 3 issue(s) that have exceeded the 30-day SLA threshold:

  1. Arbitrary Code Injection

    • ID: SNYK-JS-LODASH-15869625
    • Package: lodash@4.17.23
    • Published: 211 days ago (SLA: 30 days)
    • CVSS Score: 8.6
    • CVE: CVE-2026-4800
  2. Open Redirect

    • ID: SNYK-JS-REACTROUTER-17138887
    • Package: react-router@6.30.3
    • Published: 148 days ago (SLA: 30 days)
    • CVSS Score: 8.7
    • CVE: CVE-2026-40181
  3. Open Redirect

    • ID: SNYK-JS-REACTROUTER-18313144
    • Package: react-router@6.30.3
    • Published: 95 days ago (SLA: 30 days)
    • CVSS Score: 7.1
    • CVE: CVE-2026-53669

🟡 Medium Severity - SLA Breached Issues (with fixes)

Showing 2 issue(s) that have exceeded the 90-day SLA threshold:

  1. Prototype Pollution

    • ID: SNYK-JS-LODASH-15869619
    • Package: lodash@4.17.23
    • Published: 211 days ago (SLA: 90 days)
    • CVSS Score: 6.9
    • CVE: CVE-2026-2950
  2. Use of Externally-Controlled Input to Select Classes or Code ('Unsafe Reflection')

    • ID: SNYK-JS-REACTROUTER-18313130
    • Package: react-router@6.30.3
    • Published: 95 days ago (SLA: 90 days)
    • CVSS Score: 6
    • CVE: CVE-2026-53666

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 4
  • Medium without fixes: 0
  • Low without fixes: 0

❌ BUILD FAILED - Security checks failed

Please review and fix the security vulnerabilities before merging.

@pritesh-jain-cstk

Copy link
Copy Markdown
Author

Superseded by the split: Tests #146 (from main), Routine #147 (stacked on #146), Docs #148 (from main, draft until tests merge). Merge order: #146, #147; #148 after #146. Branch graph in each PR body and the Epic. main had moved (react-router-dom ^7) since this PR was cut, so the new branches are based on current main. Closed without merge; no code lost (lossless check passed against this PR's tree plus main's changes, lockfile regenerated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants