feat(transform)!: drop transformVerifyCalls - #344
Open
pyramation wants to merge 1 commit into
Open
Conversation
The pre-pass existed to rename schema names inside verify_*('schema.object')
literals, keyed on a hand-maintained list of helper names -- a list that
already omitted verify_security, so that call site never got renamed.
Identity casts replaced those helpers: 'sch.tbl'::regclass and friends are
routed by cast type (18.16.0), and the bare-schema case verify_schema needed
the pre-pass for is now assert_schema('sch'::regnamespace). The kitchen-sink
fixture is updated to the assertion form it replaces.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
transformVerifyCallspre-pass (and its export) from@pgsql/transform, 18.17.0. It renamed schema names inside verify helper literals by matching a hand-maintained list of helper names:That list is the failure mode it caused: it omits
verify_security, so that call site silently never got renamed, and every new helper had to be added here and in pgpm's parallelSCHEMA_NAME_LITERAL_FUNCS.Nothing needs it any more. Qualified literals (
'sch.tbl') were already reached by the genericA_Constpass, and the one case that genuinely required the name list —verify_schema('sch'), a bare name with no dot — is nowassert_schema('sch'::regnamespace), routed by cast type as of #343. constructive-db regenerates with zero drift without the pre-pass.Breaking:
transformVerifyCallsis no longer exported. Callers should drop it fromprePasses.The kitchen-sink fixture's
verify_*block is replaced with the assertion form it verifies (assert_schema(...::regnamespace),assert_function(...::regprocedure), …), and the golden output regenerated withscripts/make-fixtures.ts.Validation
pnpm testinpackages/transform: 250 passing, 12 suitespnpm lint: cleanLink to Devin session: https://app.devin.ai/sessions/37a60838adfb4fd6ac8c29f09c2e2827
Requested by: @pyramation