fix: clarify static-analysis command deprecation message - #754
Open
sentry[bot] wants to merge 1 commit into
Open
fix: clarify static-analysis command deprecation message#754sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 77 77
Lines 2984 2984
=======================================
Hits 2813 2813
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
static-analysiscommand was deprecated and its underlying service implementation (which included thePythonAnalyzerresponsible for theOSError: /dev/null/placeholderissue CLI-G0) has been removed from the codebase.This change updates the
static-analysiscommand stub to explicitly log an error message when invoked. This provides a clear, actionable message to users, informing them that the command is no longer functional and advising them to remove it from their CI configuration, rather than silently doing nothing or potentially leading to obscure errors if the original (now removed) logic were still present.Fixes CLI-G0