Repository navigation
Outdated schema validator produces validation error despite file being valid #126
Description
Reported by @hainesr via email:
The possible problem I’ve come across is that I can’t get a 1.3.0 CFF to validate due to the following error: “Validation error: #/authors/0: failed schema #/properties/authors/items: More than one subschema in "oneOf" matched.” I see that in 1.2.0 we had “anyOf” instead of “oneOf” for the authors field (again, is this a backwards incompatibility issue??) and the same CFF will validate fine with 1.2.0. Maybe it’s a validator issue, but I’m using the same validator that GitHub uses already.
We have established that the used validator in question is outdated.
Activity
sdruskat commentedon Feb 20, 2024
The problem has been reported as the validation library not resolving
$defreferences in the schema, and thus not loading the relevant subschemas.The main issue with this is that this is the same version of the validator that GitHub uses internally.
This may potentially result in breaking the GitHub citation widget if
ruby-cffis update to work with CFF version1.3.0without updating the validation library.Perhaps @arfon could advise how to handle this?
Ideally, GitHub would update the validation library in use, no?
sdruskat commentedon Feb 20, 2024
Transferring this to the
ruby-cffrepo.arfon commentedon Feb 20, 2024
@sdruskat @hainesr – does
v1.2ofcfffix this (https://rubygems.org/gems/cff/versions/1.2.0)?hainesr commentedon Feb 21, 2024
Hi @arfon, this isn't an issue with ruby-cff itself but one of its dependencies.
json_schemais no longer maintained and doesn't support newer versions of the JSON Schema standard. CFF is now using some of those features.There is talk in the
json_schemaissues [1] about directing people to usejson_schemerinstead - which is maintained and supports modern JSON Schema versions.I was wondering what GitHub have done about this. Have you moved (or are you moving) to a new JSON Schema gem? If so I could take this opportunity to do the same.
[1] brandur/json_schema#129
arfon commentedon May 27, 2024
Seems like we're pegged to
0.20.9still internally right now. I've asked around if we're planning on moving to a different gem but it doesn't seem to be a priority right now 😞