Conversation
dboyliao
force-pushed
the
dboy/xfundingv2/fee-asset
branch
6 times, most recently
from
September 2, 2026 03:40
7c72562 to
442ea17
Compare
c9s
approved these changes
Sep 2, 2026
dboyliao
force-pushed
the
dboy/xfundingv2/fee-asset
branch
from
September 23, 2026 00:53
442ea17 to
343d542
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the spot/futures prices change over time, the required fee asset amount may change as well.
Add a new
checkSufficientFeeAssetBalancemethod for checking the fee asset amount and make sure it's sufficient for opening/closing rounds.Refactor
submitFeeAssetOrdermethod to share the logic of acquiring fee asset.