Fix shared pointer property assignment in MATLAB - #200
Closed
ProfFan wants to merge 1 commit into
Closed
Conversation
Assign unwrapped shared-pointer handles directly while continuing to dereference wrapped value properties. Add focused generator coverage for both cases.
ProfFan
added a commit
to borglab/gtsam
that referenced
this pull request
Aug 21, 2026
Use the wrapper pointer DSL consistently for shared ownership and add named stereo measurement and calibration vector bindings with Python and MATLAB lifetime coverage. The MATLAB generator fix lives upstream in borglab/wrap#200.
Member
|
Let’s discuss on the GTSAM PR first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing