Test tapscript CODESEPARATOR signature positions - #1
Open
adrienlacombe wants to merge 1 commit into
Open
adrienlacombe wants to merge 1 commit into
adrienlacombe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deterministic signature regression coverage to the existing BitVM CODESEPARATOR fix #16. This targets
fix/op_codeseparatorso the tests can accompany your existing change; it does not replace or duplicate its implementation.Eight groups cover the no-separator sentinel, position zero, direct/PUSHDATA1/PUSHDATA2/PUSHDATA4 pushes, parsed but skipped instructions, skipped separators, the most recent executed separator, rejection of byte-offset signatures, and unchanged legacy/Segwit opcode limits. Expected positions are explicit constants and signatures are generated deterministically against real transaction/prevout data.
Validation: all 21 tests pass on your fix, including its existing transaction fixture. Against unchanged BitVM
ba96bc2, five of the eight new groups fail. Candidate and baseline use separate build directories to avoid shared cdylib/rlib artifacts. A separate funded Core v30.3 experiment confirms the ordinary/skipped-prefix correct-position and wrong-byte-offset transaction outcomes; integration with your fix matches all four.