fix(sidebar): keep the unread dot visible on the active channel - #6127
Open
ranjank2alpha wants to merge 1 commit into
Open
fix(sidebar): keep the unread dot visible on the active channel#6127ranjank2alpha wants to merge 1 commit into
ranjank2alpha wants to merge 1 commit into
Conversation
Signed-off-by: ranjankai <ranjan@rkai.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the channel you currently have open, the unread dot is effectively invisible.
The active row paints
bg-sidebar-active, which every theme defines asvar(--sidebar-primary)— the same hue the dot itself used unconditionally (bg-primary). So the dot draws primary-on-primary and all but disappears.That is exactly the case the dot exists for: you are reading a channel when a reply lands in a thread you do not have open, and the one signal you get is the one you cannot see.
Active rows now use the active row's foreground colour instead, the same way the muted
BellOfficon in this file already does.Also bumped 8px → 10px. The dot sits at the far end of the row with no adjacent element to give it scale, and at 8px it read as a rendering artifact rather than a deliberate indicator.