fix(inbox): clear thread activity when the thread is read - #6125
Open
ranjank2alpha wants to merge 1 commit into
Open
fix(inbox): clear thread activity when the thread is read#6125ranjank2alpha wants to merge 1 commit into
ranjank2alpha wants to merge 1 commit into
Conversation
Signed-off-by: ranjankai <ranjan@rkai.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a thread leaves every one of its replies looking unread indefinitely. The thread stays in the Inbox no matter how many times you open it — the only thing that clears it is marking each reply read individually.
resolveChannelActivityFeedItemReadAtconsults the per-message marker (msg:<id>) and the channel marker, but notthread:<rootId>— which is the one marker that reading a thread actually advances. So the read frontier moves and nothing that consumes it can see the change.getThreadReadAt, fifty lines above in the same file, already computes theright value; it just wasn't used on this path. This addsresolveThreadActivityItemReadAtto fold the thread frontier in alongside the existing markers, and uses it in theunreadThreadFeedItemsfilter.Tests cover the regression directly: a reply where only the thread marker moved, which resolved to
nullbefore this change. Also covered — a reply's own message marker still wins when it is ahead, a different thread's marker doesn't clear this one, and a reply with no resolvable root falls back to channel-level read state rather than throwing.