Conversation
Python int() accepts 1_0 as 10, so parse_path("m/1_0") derived index 10. Path components now have to be digits, with the existing harden suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_pathused Pythonint()on each path component.int("1_0")is 10, som/1_0derived index 10 instead of failing. The caller already has the path string. An underscore is not a BIP32 character, and it was changing the index. Components now have to be digits, with the existinghor'harden suffix.Test plan
parse_path("m/1_0")returned[10]before the changetest_parse_path_rejects_underscoreandtest_deriv_pathpass after the changeMade with Cursor