feat(ghidra): add comment change listener and optimize comment operations - #233
Open
maci0 wants to merge 1 commit into
Open
feat(ghidra): add comment change listener and optimize comment operations#233maci0 wants to merge 1 commit into
maci0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comment change event monitoring and optimized comment retrieval to the Ghidra decompiler interface in DecLib:
Comment Change Events (
declib/decompilers/ghidra/hooks.py):DOCR_EOL_COMMENT_CHANGED,DOCR_PRE_COMMENT_CHANGED,DOCR_POST_COMMENT_CHANGED,DOCR_PLATE_COMMENT_CHANGED,DOCR_REPEATABLE_COMMENT_CHANGED) toDataMonitor.do_change_handlerby querying the updated comment at address and invokingself._deci.comment_changed(cmt, deleted=...).Optimized Comment Retrieval & Writing (
declib/decompilers/ghidra/interface.py):_code_unit_to_commenthelper to handle comment extraction and multi-slot tag formatting ([PLATE],[PRE],[EOL],[POST],[REPEATABLE])._get_comment(addr)lookup._comments()to usegetCommentAddressIteratorfor bulk retrieval instead of iterating all code units in all functions._set_commentto handle bracketed comment tags and deletion when text is empty/None.