Repository navigation
Update 'all on one page' snippets #51
Description
The querystrings.js on the github page differs slightly from the source on github, and returns an error when run whereas the source does not.
Might be worth an update!
The querystrings.js on the github page differs slightly from the source on github, and returns an error when run whereas the source does not.
Might be worth an update!
Activity
bgrins commentedon Sep 8, 2014
The code, or the screenshot? I think the code is in sync unless if I'm missing something
hvsw commentedon Sep 8, 2014
The searchvalue argument in replace function. "//g" and "/+/g"
return { "Key": qs.split("=")[0], "Value": qs.split("=")[1], "Pretty Value": decodeURIComponent(qs.split("=")[1]).replace(//g," ") }
return { "Key": qs.split("=")[0], "Value": qs.split("=")[1], "Pretty Value": decodeURIComponent(qs.split("=")[1]).replace(/+/g," ") }
bgrins commentedon Sep 8, 2014
Ah I see that now, thanks. Maybe is a bug with the rakefile at: https://github.com/bgrins/devtools-snippets/blob/master/Rakefile, because gh-pages is up to date after running
rake buildbgrins commentedon Sep 8, 2014
Hm, well running
pygmentize -f html snippets/querystringvalues/querystringvalues.jsseems to produce the correct output so it's not thatbgrins commentedon Sep 8, 2014
And it appears OK in the snippets.json file: https://bgrins.github.io/devtools-snippets/snippets.json
bgrins commentedon Sep 9, 2014
Well, I'm not sure why but the
/+/gis still there in themarkupvariable before the call towith_markup = template.gsub(regex, markup)in the rakefile:devtools-snippets/Rakefile
Line 40 in d401680
with_markupseems to be//gas far as I can tell.