Skip to content

perf: skip redundant bindTexture in setTextureAt #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roncarbot wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

perf: skip redundant bindTexture in setTextureAt #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43591bb
perf: skip redundant bindTexture in setTextureAt
roncarbot Sep 9, 2026
c00c1c4
perf: skip redundant activeTexture in setTextureAt
roncarbot Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions lib/webgl/TextureContextWebGL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export class TextureContextWebGL {
public static MAX_SAMPLERS = 16;

_lastBoundedTexture: TextureWebGL;
_activeTextureUnit: number = -1;
_samplerStates: SamplerStateWebGL[] = [];
_currentRT: RenderTargetWebGL = null;

Expand Down Expand Up @@ -109,14 +110,10 @@ export class TextureContextWebGL {
public setTextureAt(sampler: number, texture: TextureWebGL): number {
const gl = this._context._gl;
const samplerState = this._samplerStates[sampler];
const textureType = GL_MAP.TEXTURE[texture.textureType];

if ((texture || samplerState.type)) {
gl.activeTexture(gl.TEXTURE0 + sampler);
}

if (!texture) {
if (samplerState.type) {
this._activateTextureUnit(sampler);

// disable link to sampler in bounded texture
if (samplerState.boundedTexture) {
Expand All @@ -132,15 +129,33 @@ export class TextureContextWebGL {
return -1;
}

const textureType = GL_MAP.TEXTURE[texture.textureType];
const alreadyBound = samplerState.boundedTexture === texture && samplerState.type === textureType;
// commit early-outs when wrap/filter already match texture._state
const paramsDirty = !alreadyBound || !samplerState.equals(texture._state);

// Skip activeTexture when unit is active, texture already bound, params unchanged.
if (!alreadyBound || paramsDirty || this._activeTextureUnit !== sampler)
this._activateTextureUnit(sampler);

texture._state.id = sampler;

this.bindTexture(texture, false, textureType);
// Skip redundant GL bindTexture when this sampler already holds the texture.
this.bindTexture(texture, alreadyBound, textureType);

samplerState.commit(textureType, texture);
samplerState.boundedTexture = texture;

return sampler;
}

private _activateTextureUnit(sampler: number): void {
if (this._activeTextureUnit === sampler)
return;
this._activeTextureUnit = sampler;
this._gl.activeTexture(this._gl.TEXTURE0 + sampler);
}

public setSamplerStateAt(
sampler: number,
wrap: ContextGLWrapMode,
Expand Down