This repository was archived by the owner on Mar 28, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 28, 2025. It is now read-only.
use_concat_filter:=false is not supported #76
Description
Checklist
- I've read the contribution guidelines.
- I've searched other issues and no duplicate issues were found.
- I'm convinced that this is not my fault but a bug.
Description
The lidar preprocessing pipeline is broken if use_concat_filter is set to false. In the preprocessor launch file, it is suggested that if the concatenate filter is not used then a passthrough filter is launch. However it is not the case:
This would leave the lidar pipeline broken, has /sensing/lidar/top/outlier_filtered/pointcloud messages are not forwarded to /sensing/lidar/concatenated/pointcloud (which is hardcoded everywhere in other autoware modules).
Either a passthrough should be added, or the option should rather be removed?
Expected behavior
Since use_concat_filter is an option, we should be able to use it.
Actual behavior
use_concat_filter:=false does not work.
Steps to reproduce
N/A
Versions
No response
Possible causes
No response
Additional context
No response
Activity
stale commentedon Nov 13, 2023
This pull request has been automatically marked as stale because it has not had recent activity.
vividf commentedon Nov 13, 2024
In my opinion, I think we can remove the
use_concat_filterparameter because if users only have one lidar (which do not need to concatenate), then they can use thesingle_lidar_sensor_kit_launchstale commentedon Jan 14, 2025
This pull request has been automatically marked as stale because it has not had recent activity.