fix: count codepoints on the stored value, not a normalized copy - #261
Merged
zachdaniel merged 1 commit intoSep 10, 2026
Merged
Conversation
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Summary
Makes
string_length(..., :codepoints)return what Postgres itself answers for the stored value.Reported downstream as ash_postgres#845, where a
max_lengthconstraint is enforced against a recomposed copy in the database and against the stored value in Elixir, so a value can be written which may be rejected by the same constraint on the way back. ash_sql was counting a recomposed copy rather than the stored value.Enables an ash_postgres test PR:
chore/string-length-tests, red against ash_sql 0.7.3 and green against this branch