Skip to content

fix(databases): redirect legacy collection links to tables - #3196

Open
HarshMN2345 wants to merge 3 commits into
mainfrom
codex/sentry-legacy-collection
Open

fix(databases): redirect legacy collection links to tables#3196
HarshMN2345 wants to merge 3 commits into
mainfrom
codex/sentry-legacy-collection

Conversation

@HarshMN2345

@HarshMN2345 HarshMN2345 commented Sep 10, 2026

Copy link
Copy Markdown
Member

Fixes CONSOLE-RE0.

Old collection-<id> links for legacy databases successfully load a table through the shared SDK dispatcher, then fail when the collection page requests a DocumentsDB/VectorsDB-only client. Redirect legacy and TablesDB collection links to the corresponding table route before loading the entity. Preserve nested pages and query parameters, and keep DocumentsDB/VectorsDB on the collection route.

For the reported collection-<id>/document-<id> deep link, populate the existing table row sheet before redirecting, preserving the requested record. Genuine DocumentsDB/VectorsDB document links continue using the collection sheet.

The redirect uses the existing route resolver and 308 convention. Regression coverage exercises the actual catchall and layout load functions with real sheet stores, including indexes/settings/export, encoded filters, native row links, and both supported collection database types.

Validation:

  • Five layout redirect cases fail before the production change. Two exact legacy/TablesDB document-link cases fail before the catchall change; all twelve route cases pass afterward.
  • Full unit suite: 303 tests across 17 files pass.
  • bun run format, bun run check, bun run lint, bun run build, and bun audit --audit-level high pass. Existing repository warnings remain; changed TypeScript files have no warnings.
  • bun run tests -- --list runs the unit suite and lists the three Playwright journeys. The existing journeys create accounts/projects against staging and were not executed locally.
  • Latest-head CI build and Playwright E2E jobs pass. Greptile: 5/5 at 971bed4a91ca048d5bd286198f07e21777852765.

@appwrite

appwrite Bot commented Sep 10, 2026

Copy link
Copy Markdown

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Appwrite has crossed the 50K GitHub stars milestone with hundreds of active contributors

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the redirect and deep-link behavior consistently handled across supported database types.

Summary

  • Routes legacy collection document links to the corresponding row sheet.
  • Keeps DocumentsDB and VectorsDB document links on the collection sheet.
  • Adds regression coverage for redirects, nested routes, query parameters, and record deep links.

Reviews (2) 路 Last reviewed commit: "test(databases): assert observable redir..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant