Repository navigation
feat: force the returned value in test.catch() and test.catchOrNull() - #1910
Merged
Merged
Conversation
bioball
requested changes
Oct 16, 2026
bioball
left a comment
bioball
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! This generally looks good, just some comments.
Move the test to api/testModule.pkl and reword the stdlib docs.
bioball
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1899.
test.catch()andtest.catchOrNull()applied the lambda but did not force its result, so a lazily failing value such asnew Listing { 1 } as Listing<String>did not throw inside the call.Both now force the returned value (
VmValue.force(result, false), the same forcing rendering does), so errors in its members are caught. The behavior is documented on both functions.In the
as3snippet test, twocatchOrNull(...) == nullresults change fromtruetofalse, because those values now throw when forced. I also added the example from the issue.I could not run the Gradle build locally (disk space), so CI will be the first full run of the language snippet tests.