NIFI-16250 Treat an unconfigured SECRET_REFERENCE as unset - #11591
Merged
Conversation
A SECRET property with no secret selected can be stored as a SECRET_REFERENCE carrying only a provider name. Both helpers relied on buildSecretKey, which never returns an empty string, so the select showed an unmatched key like "::Some Provider::" and hasPropertyValue reported the property as configured. Both now check fullyQualifiedSecretName and secretName directly.
Contributor
|
Will review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A SECRET property with no secret selected can be stored as a SECRET_REFERENCE carrying only a provider name. Both helpers relied on buildSecretKey, which never returns an empty string, so the select showed an unmatched key like "::Some Provider::" and hasPropertyValue reported the property as configured.
Both now check fullyQualifiedSecretName and secretName directly.
Summary
NIFI-16250
A SECRET property with no secret selected can be stored as a
SECRET_REFERENCEcarrying only a provider name.
fromValueReferenceandhasPropertyValuebothrelied on
buildSecretKey, which never returns an empty string, so the secretselect showed an unmatched key like
::Some Provider::instead of itsplaceholder, and
hasPropertyValuereported the property as configured.Both now check
fullyQualifiedSecretNameandsecretNamedirectly. A referencecarrying a
secretNamebut nofullyQualifiedSecretNameis still consideredconfigured.
Because
PropertyGroupCardresolveshasValuethroughhasPropertyValue, theconfiguration summary and connector details pages previously showed such a
property as having a value. They now show "No value set".
Verified with
nx test shared(941 tests),nx lint shared, andnx build shared.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation