[INLONG-12202][SDK] Close connPool before netClient to avoid dial goroutine leak in Dataproxy Go SDK - #12209
Open
yfsn666 wants to merge 1 commit into
Open
[INLONG-12202][SDK] Close connPool before netClient to avoid dial goroutine leak in Dataproxy Go SDK#12209yfsn666 wants to merge 1 commit into
yfsn666 wants to merge 1 commit into
Conversation
…outine leak in Dataproxy Go SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12202
Motivation
In the Dataproxy Go SDK, subsequent Dial calls can block forever in EnrollContext once the gnet event-loop has exited during client close, causing goroutine leaks.
Modifications
Reordered the shutdown sequence in
client.Close()to close the connection pool before stopping the netClient, reducing the window in which new dials can enterEnrollContextafter the event-loop has already stopped.Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation