Skip to content

IGNITE-29052 Fix flaky IgniteCacheGroupsTest.testRestartsAndCacheCreateDestroy #13581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wernerdv wants to merge 6 commits into
base: master
Choose a base branch
from
+43 −16
Open

IGNITE-29052 Fix flaky IgniteCacheGroupsTest.testRestartsAndCacheCreateDestroy #13581

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db38e45
IGNITE-29052 Fix flaky IgniteCacheGroupsTest.testRestartsAndCacheCrea…
wernerdv Sep 12, 2026
14c0afd
fix
wernerdv Sep 14, 2026
e4b0001
fix v2
wernerdv Sep 14, 2026
37d40f1
fix v3
wernerdv Sep 15, 2026
3a232f2
fix v4
wernerdv Sep 16, 2026
13229ad
fix v5
wernerdv Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 43 additions & 16 deletions ...core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheGroupsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import java.util.concurrent.atomic.AtomicReference;
import java.util.concurrent.atomic.AtomicReferenceArray;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
import javax.cache.Cache;
import javax.cache.CacheException;
import javax.cache.configuration.Factory;
Expand Down Expand Up @@ -3729,6 +3730,13 @@ public void testRestartsAndCacheCreateDestroy() throws Exception {
final AtomicBoolean stop = new AtomicBoolean();
final AtomicInteger cacheCntr = new AtomicInteger();

// Client-side cache create/destroy and node restart both trigger a distributed exchange. When they run
// concurrently, a client-initiated exchange can deadlock with the node re-join (client never receives the
// coordinator's final message), blocking the whole cluster. Serialize them so that a node restart never
// overlaps an in-flight client create/destroy, while ordinary cache operations still run concurrently with
// restarts.
final ReentrantLock restartLock = new ReentrantLock();

try {
final int ITERATIONS_CNT = SF.applyLB(10, 1);
for (int i = 0; i < ITERATIONS_CNT; i++) {
Expand All @@ -3748,13 +3756,20 @@ public void testRestartsAndCacheCreateDestroy() throws Exception {

log.info("Stop node: " + node);

stopGrid(node);
restartLock.lock();

try {
stopGrid(node);

U.sleep(500);
U.sleep(500);

log.info("Start node: " + node);
log.info("Start node: " + node);

startGrid(node);
startGrid(node);
}
finally {
restartLock.unlock();
}

try {
if (rnd.nextBoolean())
Expand Down Expand Up @@ -3788,15 +3803,22 @@ public void testRestartsAndCacheCreateDestroy() throws Exception {
if (cache != null && caches.compareAndSet(idx, cache, null)) {
log.info("Destroy cache: " + cache.getName());

clientNode.destroyCache(cache.getName());
restartLock.lock();

try {
clientNode.destroyCache(cache.getName());

CacheAtomicityMode atomicityMode = rnd.nextBoolean() ? ATOMIC : TRANSACTIONAL;
CacheAtomicityMode atomicityMode = rnd.nextBoolean() ? ATOMIC : TRANSACTIONAL;

String name = "newName-" + cacheCntr.incrementAndGet();
String name = "newName-" + cacheCntr.incrementAndGet();

cache = clientNode.createCache(
cacheConfiguration(atomicityMode == ATOMIC ? GROUP1 : GROUP2,
name, PARTITIONED, atomicityMode, 0, false));
cache = clientNode.createCache(
cacheConfiguration(atomicityMode == ATOMIC ? GROUP1 : GROUP2,
name, PARTITIONED, atomicityMode, 0, false));
}
finally {
restartLock.unlock();
}

caches.set(idx, cache);
}
Expand Down Expand Up @@ -3880,16 +3902,21 @@ public void testRestartsAndCacheCreateDestroy() throws Exception {
}

for (int n = 0; n < SRVS; n++) {
CacheGroupContext grp = cacheGroup(ignite(n), GROUP1);
for (String grpName : Arrays.asList(GROUP1, GROUP2)) {
CacheGroupContext grp = cacheGroup(ignite(n), grpName);

assertNotNull(grp);
// Group may be absent on a node if all its caches were
// re-created under another group during this iteration.
if (grp == null)
continue;

for (GridDhtLocalPartition part : grp.topology().currentLocalPartitions()) {
IntMap<Object> cachesMap = GridTestUtils.getFieldValue(part, "cacheMaps");
for (GridDhtLocalPartition part : grp.topology().currentLocalPartitions()) {
IntMap<Object> cachesMap = GridTestUtils.getFieldValue(part, "cacheMaps");

assertTrue(cachesMap.size() <= cacheIds.size());
assertTrue(cachesMap.size() <= cacheIds.size());

cachesMap.forEach((cacheId, v) -> assertTrue(cachesMap.containsKey(cacheId)));
cachesMap.forEach((cacheId, v) -> assertTrue(cachesMap.containsKey(cacheId)));
}
}
}
}
Expand Down
Loading