feat: add java.sql.Date converters (#1017) - #1079
Open
Anubyss-mihail wants to merge 1 commit into
Open
Conversation
Anubyss-mihail
force-pushed
the
feat-sql-date-converters-1017
branch
4 times, most recently
from
September 9, 2026 16:05
d4fe0d9 to
2e206e3
Compare
Comment on lines
+34
to
+36
| * Date and number converter | ||
| * | ||
| * |
Contributor
There was a problem hiding this comment.
The current Javadoc (“Date and number converter”) doesn’t fully match the actual implementation, which is specifically a java.sql.Date converter.
Could you update the Javadoc, and also remove the unused blank comment lines?
Anubyss-mihail
force-pushed
the
feat-sql-date-converters-1017
branch
from
September 10, 2026 15:59
2e206e3 to
998247f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related: #1017
Add support for
java.sql.Dateconversion.What's changed?
DefaultConverterLoader.Checklist